cloud-fan commented on a change in pull request #26808: [SPARK-30184][SQL]
Implement a helper method for aliasing functions
URL: https://github.com/apache/spark/pull/26808#discussion_r355816787
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -431,7 +431,7 @@ object functions {
* @since 2.0.0
*/
def first(e: Column, ignoreNulls: Boolean): Column = withAggregateFunction {
- new First(e.expr, Literal(ignoreNulls))
+ new First("first", e.expr, Literal(ignoreNulls))
Review comment:
We can add a constructor to provide a default name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
