cloud-fan commented on a change in pull request #26808: [SPARK-30184][SQL]
Implement a helper method for aliasing functions
URL: https://github.com/apache/spark/pull/26808#discussion_r356135812
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##########
@@ -198,7 +198,7 @@ object RewriteDistinctAggregates extends Rule[LogicalPlan]
{
// Select the result of the first aggregate in the last aggregate.
val result = AggregateExpression(
- aggregate.First(evalWithinGroup(regularGroupId,
operator.toAttribute), Literal(true)),
+ new aggregate.First(evalWithinGroup(regularGroupId,
operator.toAttribute), Literal(true)),
Review comment:
so adding more constructors doesn't help us to reduce diff, how about
```
case class First(funcName: String, child: Expression, ignoreNullsExpr:
Expression) {
def this(funcName: String, child: Expression)
}
object First {
def apply(child: Expression, ignoreNullsExpr: Expression) ...
def apply(child: Expression) ...
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
