beliefer commented on a change in pull request #26656: [SPARK-27986][SQL]
Support ANSI SQL filter clause for aggregate expression
URL: https://github.com/apache/spark/pull/26656#discussion_r358695732
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##########
@@ -183,9 +183,12 @@ object RewriteDistinctAggregates extends
Rule[LogicalPlan] {
// only expand unfoldable children
val regularAggExprs = aggExpressions
.filter(e => !e.isDistinct && e.children.exists(!_.foldable))
- val regularAggChildren = regularAggExprs
+ val regularAggFunChildren = regularAggExprs
.flatMap(_.aggregateFunction.children.filter(!_.foldable))
- .distinct
+ val regularAggFilterChildren = regularAggExprs
+ .flatMap(ae => ae.filter.map(_.children.filter(!_.foldable)))
+ .flatten
+ val regularAggChildren = (regularAggFunChildren ++
regularAggFilterChildren).distinct
Review comment:
OK. I forgot it when I revert it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
