beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r358719472
########## File path: docs/sql-keywords.md ########## @@ -117,6 +117,7 @@ Below is a list of all the keywords in Spark SQL. <tr><td>FALSE</td><td>reserved</td><td>non-reserved</td><td>reserved</td></tr> <tr><td>FETCH</td><td>reserved</td><td>non-reserved</td><td>reserved</td></tr> <tr><td>FIELDS</td><td>non-reserved</td><td>non-reserved</td><td>non-reserved</td></tr> + <tr><td>FILTER</td><td>non-reserved</td><td>non-reserved</td><td>reserved</td></tr> Review comment: @cloud-fan There exists a issue as below: https://github.com/apache/spark/blob/bf7215c510e0eb2afa0a8f1337c535b4091f08f9/sql/core/src/test/resources/sql-tests/results/ansi/higher-order-functions.sql.out#L85 ``` no viable alternative at input 'filter'(line 1, pos 7) == SQL == select filter(ys, y -> y > 30) as v from nested -------^^^ ``` filter is a function. It seems we can't put the keyword in `ansiNonreserved` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
