seayoun commented on a change in pull request #26975: [SPARK-30325][CORE] Stage retry and executor crash cause app hung up forever URL: https://github.com/apache/spark/pull/26975#discussion_r361074152
########## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ########## @@ -698,9 +704,13 @@ private[spark] class TaskSetManager( totalResultSize -= resultSizeAcc.get.asInstanceOf[LongAccumulator].value } + val killedReason = if (killedByOtherAttempt.contains(tid)) { + TaskKilled("Finish but did not commit due to another attempt succeeded") + } else { + TaskKilled("Finish but did not commit due to task in another stage retry succeeded") Review comment: `killedByOtherStageRetries` is also used in `executorLost` to avoid `Resubmitted`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org