Github user rdblue commented on a diff in the pull request: https://github.com/apache/incubator-toree/pull/128#discussion_r127858771 --- Diff: kernel/src/main/scala/org/apache/toree/kernel/api/Kernel.scala --- @@ -20,8 +20,11 @@ package org.apache.toree.kernel.api import java.io.{InputStream, PrintStream} import java.net.URI import java.util.concurrent.{ConcurrentHashMap, TimeUnit, TimeoutException} + --- End diff -- Nit: unnecessary changes in imports make backports and branch maintenance harder. I'd prefer not to have these changes unless there is a stated style that this changes conforms to.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---