Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/incubator-toree/pull/128#discussion_r127858615
  
    --- Diff: kernel/src/main/scala/org/apache/toree/kernel/api/Kernel.scala ---
    @@ -414,13 +417,15 @@ class Kernel (
               Await.result(sessionFuture, Duration(100, TimeUnit.MILLISECONDS))
             } catch {
               case timeout: TimeoutException =>
    -            // getting the session is taking a long time, so assume that 
Spark
    -            // is starting and print a message
    -            display.content(
    -              MIMEType.PlainText, "Waiting for a Spark session to 
start...")
    +            // in cluster mode, the sparkContext is forced to initialize
    +            if (SparkUtils.isSparkClusterMode(defaultSparkConf) == false) {
    --- End diff --
    
    Instead of preventing the message from being sent, I think this should 
update the logic so that this uses the second case. That case just creates a 
new context without the futures or Await calls.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to