kevinjmh commented on code in PR #4730:
URL: https://github.com/apache/zeppelin/pull/4730#discussion_r1522799048
##########
jdbc/src/main/java/org/apache/zeppelin/jdbc/SqlCompleter.java:
##########
@@ -217,11 +217,11 @@ public static Set<String>
getSqlKeywordsCompletions(DatabaseMetaData meta) throw
Set<String> completions = new TreeSet<>();
if (null != meta) {
Review Comment:
I should clarify that the NPE shows in the screenshot is not throwed here,
but `meta.getDriverName` is the root cause which throw an exception ->
`keywords` is empty -> `keywordCompleter` is not initialized -> calling
`completeKeyword` throw the exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
