kevinjmh commented on code in PR #4730:
URL: https://github.com/apache/zeppelin/pull/4730#discussion_r1524080551
##########
jdbc/src/main/java/org/apache/zeppelin/jdbc/SqlCompleter.java:
##########
@@ -217,11 +217,11 @@ public static Set<String>
getSqlKeywordsCompletions(DatabaseMetaData meta) throw
Set<String> completions = new TreeSet<>();
if (null != meta) {
Review Comment:
However, exception is thrown once calling `getDriverName` , then `keywords`
mentioned above cannot return and completer cannot work.
Methods in the driver classes are implemented by other developers. We cannot
ensure their actions, so put them in try-catch is more code-safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
