jongyoul commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1579116839
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java:
##########
@@ -34,14 +36,14 @@
public class RemoteScheduler extends AbstractScheduler {
private static final Logger LOGGER =
LoggerFactory.getLogger(RemoteScheduler.class);
- private RemoteInterpreter remoteInterpreter;
- private ExecutorService executor;
+ private final RemoteInterpreter remoteInterpreter;
+ private final ExecutorService executor;
public RemoteScheduler(String name,
- ExecutorService executor,
RemoteInterpreter remoteInterpreter) {
super(name);
- this.executor = executor;
+ this.executor =
+ Executors.newSingleThreadExecutor(new SchedulerThreadFactory("FIFO-" +
name + "-"));
Review Comment:
IIRC, concurrent execution for jdbc interpreter is being handled by JDBC
interpreter. As you mentioned, we also designed to select two types of
interpreter for remote interpreter but it was not developed well in my
understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
