Reamer commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1580545670
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java:
##########
@@ -34,14 +36,14 @@
public class RemoteScheduler extends AbstractScheduler {
private static final Logger LOGGER =
LoggerFactory.getLogger(RemoteScheduler.class);
- private RemoteInterpreter remoteInterpreter;
- private ExecutorService executor;
+ private final RemoteInterpreter remoteInterpreter;
+ private final ExecutorService executor;
public RemoteScheduler(String name,
- ExecutorService executor,
RemoteInterpreter remoteInterpreter) {
super(name);
- this.executor = executor;
+ this.executor =
+ Executors.newSingleThreadExecutor(new SchedulerThreadFactory("FIFO-" +
name + "-"));
Review Comment:
Synchronization between the Zeppelin server and the remote interpreters is
not easy. Currently, the Zeppelin server sends one paragraph per paragraph to a
remote interpreter in order to delete the queue locally in the event of an
abort.
A clean implementation would be needed so that the Zeppelin server can
cancel jobs (paragraphs) in the remote interpreter. The Zeppelin server should
only send several jobs (paragraphs) to the remote interpreter if such an
implementation is available. The remote interpreter can then of course work in
parallel or sequentially, depending on the actual interpreter and configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
