pan3793 commented on PR #4797: URL: https://github.com/apache/zeppelin/pull/4797#issuecomment-2296437413
integrating thrift codegen into the regular build process makes the developer hard to set up the environment, because thrift community does not publish the convenient `thrift` binary on releases, the downstream developers have to build thrift from source or get from the platform package managers like apt/brew, neither ways are convenient due it additional native deps requirements or only a few of versions providing. given the generated thrift code won't change frequently, tracking the generated thrift code and providing a script to regenerate it is a common way. I think we can make some improvements in `genthrift.sh`, for example, make it working dir agnostic, allow passing env `THRIFT_EXEC` to use a custom `thrift` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
