pan3793 commented on code in PR #4797: URL: https://github.com/apache/zeppelin/pull/4797#discussion_r1758068663
########## zeppelin-interpreter/src/main/thrift/genthrift.sh: ########## @@ -17,176 +17,25 @@ # * limitations under the License. # */ +# Determine the base directory dynamically (directory where the script is located) +THRIFT_EXEC="$(dirname "$(realpath "$0")")" Review Comment: why I prefer `THRIFT_EXEC` instead of `THRIFT_HOME`? the `thrift` binary has no extra dependency and can be copied to any folder directly, for example, I put the thrift binaries under `$HOME/bin` ``` $ ll bin | grep thrift lrwxr-xr-x@ 1 chengpan staff 13B Aug 19 19:35 thrift -> thrift-0.16.0 -rwxr-xr-x@ 1 chengpan staff 3.4M Aug 19 11:13 thrift-0.14.1 -r-xr-xr-x@ 1 chengpan staff 3.3M Aug 19 18:35 thrift-0.16.0 -r-xr-xr-x@ 1 chengpan staff 3.6M Aug 1 10:15 thrift-0.20.0 -rwxr-xr-x@ 1 chengpan staff 2.9M Aug 19 11:12 thrift-0.9.3 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
