Reamer commented on code in PR #4908:
URL: https://github.com/apache/zeppelin/pull/4908#discussion_r2012297965
##########
hbase/src/main/java/org/apache/zeppelin/hbase/HbaseInterpreter.java:
##########
@@ -143,30 +145,25 @@ public Scheduler getScheduler() {
HbaseInterpreter.class.getName() + this.hashCode());
}
- @Override
- public List<InterpreterCompletion> completion(String buf, int cursor,
- InterpreterContext interpreterContext) {
- return null;
+ private String getScriptFileName(String paragraphId) {
+ return String.format("%s%s.txt", getScriptDir(), paragraphId);
}
- private static String getSystemDefault(
- String envName,
- String propertyName,
- String defaultValue) {
-
- if (envName != null && !envName.isEmpty()) {
- String envValue = System.getenv().get(envName);
- if (envValue != null) {
- return envValue;
- }
+ private String getScriptDir() {
+ String tmpProperty = System.getProperty("java.io.tmpdir");
Review Comment:
I'm not a fan of fixed strings. We should use a method directly from Java to
create a temp directory or file.
The path must of course be memorized in order to remove it again later.
Files.createTempFile or Files.createTempDirectory should be useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
