paul8263 commented on code in PR #4908:
URL: https://github.com/apache/zeppelin/pull/4908#discussion_r2017772301
##########
hbase/src/main/java/org/apache/zeppelin/hbase/HbaseInterpreter.java:
##########
@@ -143,30 +156,26 @@ public Scheduler getScheduler() {
HbaseInterpreter.class.getName() + this.hashCode());
}
- @Override
- public List<InterpreterCompletion> completion(String buf, int cursor,
- InterpreterContext interpreterContext) {
- return null;
+ private void stopProcess(String paragraphId) {
+ if (runningProcesses.containsKey(paragraphId)) {
+ final Executor executor = runningProcesses.get(paragraphId);
+ final ExecuteWatchdog watchdog = executor.getWatchdog();
+ watchdog.destroyProcess();
+ runningProcesses.remove(paragraphId);
+ }
}
- private static String getSystemDefault(
- String envName,
- String propertyName,
- String defaultValue) {
-
- if (envName != null && !envName.isEmpty()) {
- String envValue = System.getenv().get(envName);
- if (envValue != null) {
- return envValue;
- }
- }
+ private File createTempFile(String paragraphId) throws IOException {
+ File temp = Files.createTempFile(
+ Paths.get(System.getProperty("java.io.tmpdir"),
"zeppelin-hbase-scripts"), paragraphId, ".txt").toFile();
+ tempFiles.put(paragraphId, temp);
+ return temp;
+ }
- if (propertyName != null && !propertyName.isEmpty()) {
- String propValue = System.getProperty(propertyName);
- if (propValue != null) {
- return propValue;
- }
+ private void deleteTempFile(String paragraphId) {
+ if (tempFiles.containsKey(paragraphId)) {
Review Comment:
@Reamer ,
Great idea. As the return value of the map's remove method indicates the
entry to be removed, we should use it instead, avoiding iterating the map again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
