Re: [PR] [ZEPPELIN-6204] do not allow init params in JDBC URLs for H2 [zeppelin]

[via GitHub]

tbonelee commented on code in PR #4949:
URL: https://github.com/apache/zeppelin/pull/4949#discussion_r2202685722


##########
jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:
##########
@@ -589,17 +597,123 @@ public Connection getConnection(InterpreterContext 
context)
   }
 
   private void validateConnectionUrl(String url) {
-    String decodedUrl;
-    decodedUrl = URLDecoder.decode(url, StandardCharsets.UTF_8);
+    final String decodedUrl = urlDecode(url, url, 0);
+    final Map<String, String> params = parseUrlParameters(decodedUrl);

Review Comment:
   Just a small thought. I was wondering if decoding the full URL before 
parsing could lead to unexpected behavior in some edge cases. For example, if a 
parameter value contains encoded characters like `%26` (&) or `%3D` (=), 
decoding them too early might interfere with how the parameters are parsed.
   
   I’m not sure if values like passwords are actually allowed or commonly used 
in this context, so this might not be relevant. But I thought it was worth 
mentioning just in case. 🙏



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org