pjfanning commented on PR #4949: URL: https://github.com/apache/zeppelin/pull/4949#issuecomment-3065736752
> Just a small thought. I was wondering if decoding the full URL before parsing could lead to unexpected behavior in some edge cases. For example, if a parameter value contains encoded characters like `%26` (&) or `%3D` (=), decoding them too early might interfere with how the parameters are parsed. > > Iām not sure if values like passwords are actually allowed or commonly used in this context, so this might not be relevant. But I thought it was worth mentioning just in case. š The code in this PR ignores the param values. It only worries about the param names. The original URL as entered by the user is passed to the JDBC layer - my code splits up the URL but only for my checks for suspicious param names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
