tbonelee commented on code in PR #4952:
URL: https://github.com/apache/zeppelin/pull/4952#discussion_r2203455809
##########
zeppelin-web-angular/src/app/services/completion.service.ts:
##########
@@ -76,12 +78,19 @@ export class CompletionService extends
MessageListenersManager {
take(1),
map(d => {
return {
- suggestions: d.completions.map(i => ({
- kind: monaco.languages.CompletionItemKind.Keyword,
- label: i.name,
- insertText: i.name,
- range: undefined
- }))
+ suggestions: d.completions.map(
+ (i): languages.CompletionItem => ({
+ kind: languages.CompletionItemKind.Keyword,
+ label: i.name,
+ insertText: i.name,
+ range: {
+ startLineNumber: position.lineNumber,
+ endLineNumber: position.lineNumber,
+ startColumn: word.startColumn,
+ endColumn: word.endColumn
+ }
+ })
+ )
Review Comment:
Thanks for the review!
This change is actually just adding the default values for the `range`
property, which has has been required since v0.16.0.
You can find more details in the
[CHANGELOG.md](https://github.com/microsoft/monaco-editor/blob/f420968fc91d2d10d9d3e47dc52e2f2bda0778dd/CHANGELOG.md?plain=1#L1019)
or in [this VSCode issue](https://github.com/microsoft/vscode/issues/63454).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
