Henry-Hong commented on code in PR #4952:
URL: https://github.com/apache/zeppelin/pull/4952#discussion_r2204176462
##########
zeppelin-web-angular/src/app/services/completion.service.ts:
##########
@@ -76,12 +78,19 @@ export class CompletionService extends
MessageListenersManager {
take(1),
map(d => {
return {
- suggestions: d.completions.map(i => ({
- kind: monaco.languages.CompletionItemKind.Keyword,
- label: i.name,
- insertText: i.name,
- range: undefined
- }))
+ suggestions: d.completions.map(
+ (i): languages.CompletionItem => ({
+ kind: languages.CompletionItemKind.Keyword,
+ label: i.name,
+ insertText: i.name,
+ range: {
+ startLineNumber: position.lineNumber,
+ endLineNumber: position.lineNumber,
+ startColumn: word.startColumn,
+ endColumn: word.endColumn
+ }
+ })
+ )
Review Comment:
Oh, so it wasn’t about the UI changes after all.
I assumed the updated version supported inline suggestions and that you had
implemented that.
But from what I see, it looks like you just filled in the required values
while keeping the previous UI, right?
Sorry for the interruption! and Thank you for the detailed reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
