dididy commented on code in PR #5065:
URL: https://github.com/apache/zeppelin/pull/5065#discussion_r2330094948
##########
zeppelin-web-angular/src/app/pages/workspace/workspace.component.ts:
##########
@@ -11,11 +11,11 @@
*/
import { ChangeDetectionStrategy, ChangeDetectorRef, Component, HostListener,
OnDestroy, OnInit } from '@angular/core';
-import { isRecord } from '@zeppelin/utility/type-utility';
+import { publishedSymbol } from '@zeppelin/core';
+import { isRecord } from '@zeppelin/utility';
import { Subject } from 'rxjs';
import { takeUntil } from 'rxjs/operators';
-import { publishedSymbol } from '@zeppelin/core/paragraph-base/published';
import { HeliumManagerService } from '@zeppelin/helium-manager';
import { MessageService } from '@zeppelin/services';
import { setTheme } from '@zeppelin/visualizations/g2.config';
Review Comment:
I think `src/app/visualizations` could also be imported as
`@zeppelin/visualizations`.
Most of the folders under `src/app` are already set up with `public-api.ts`
and `index.ts`, which allows importing directly from that folder depth. I
believe we could apply the same approach here as well (though I wasn’t aware of
the existing context behind this setup, so I’d like to be cautious).
https://github.com/dididy/zeppelin/commit/ce0b4b3d5417df8d5301c71a00fd20bfc7c85284
You can see an example of this in the commit above.
I’m also aware that `projects/zeppelin-visualization` is already imported as
`@zeppelin/visualization`. Since the naming might feel a bit similar, it could
cause some confusion—but I’d like to suggest handling it this way for
consistency with the existing convention. If there was another reason behind
it, it might not need to be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
