dididy commented on PR #5065: URL: https://github.com/apache/zeppelin/pull/5065#issuecomment-3266094708
https://github.com/dididy/zeppelin/commit/044685dd0888c5eea42253133caa579d5cbe6e8a There’s a weird case where imports go one level deeper than they should. This could also be fixed in this PR. You can check it in the above commit. --- It’s just a simple suggestion, but for `index.ts` files that gather exports, it might be better to sort them alphabetically. What do you think? There should be a TSLint rule for this. It’s applied here, but there are many places overall where it’s not yet enforced. --- `note-action.service.ts` also seems to have been moved appropriately in context. This PR helped me better understand the roles within the `zeppelin-web-angular`. The criteria for using SDK messages versus `message.service`, and situations where they were mixed, were a bit confusing, but they seem well clarified now. Thank you for creating a good PR and contributing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
