tbonelee commented on code in PR #5072:
URL: https://github.com/apache/zeppelin/pull/5072#discussion_r2361541828
##########
zeppelin-web-angular/pom.xml:
##########
@@ -54,82 +63,57 @@
</plugin>
<plugin>
- <groupId>com.github.eirslett</groupId>
- <artifactId>frontend-maven-plugin</artifactId>
- <configuration>
-
<nodeDownloadRoot>${plugin.frontend.nodeDownloadRoot}</nodeDownloadRoot>
- <npmDownloadRoot>${plugin.frontend.npmDownloadRoot}</npmDownloadRoot>
- </configuration>
-
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-antrun-plugin</artifactId>
<executions>
+
<execution>
- <id>install node</id>
- <goals>
- <goal>install-node-and-npm</goal>
- </goals>
+ <id>start-zeppelin</id>
+ <phase>pre-integration-test</phase>
<configuration>
- <nodeVersion>${node.version}</nodeVersion>
- <npmVersion>${npm.version}</npmVersion>
+ <skip>${web.e2e.disabled}</skip>
+ <target unless="skipTests">
+ <exec executable="./zeppelin-daemon.sh"
dir="${zeppelin.daemon.package.base}" spawn="false">
+ <arg value="start" />
+ </exec>
+ </target>
</configuration>
- </execution>
-
- <execution>
- <id>npm install</id>
<goals>
- <goal>npm</goal>
+ <goal>run</goal>
</goals>
- <configuration>
- <skip>${web.e2e.enabled}</skip>
- <arguments>ci</arguments>
- </configuration>
</execution>
<execution>
- <id>npm build</id>
- <goals>
- <goal>npm</goal>
- </goals>
+ <id>playwright-install</id>
+ <phase>pre-integration-test</phase>
<configuration>
- <skip>${web.e2e.enabled}</skip>
- <arguments>run build</arguments>
+ <skip>${web.e2e.disabled}</skip>
+ <target unless="skipTests">
+ <exec executable="./node/npx" spawn="false">
+ <arg line="[email protected] install --with-deps" />
+ </exec>
+ </target>
</configuration>
- </execution>
-
- <execution>
- <id>npm lint</id>
<goals>
- <goal>npm</goal>
+ <goal>run</goal>
</goals>
- <phase>test</phase>
- <configuration>
- <arguments>run lint</arguments>
- </configuration>
</execution>
<execution>
- <id>npm test</id>
- <goals>
- <goal>npm</goal>
- </goals>
- <phase>test</phase>
+ <id>stop-zeppelin</id>
+ <phase>post-integration-test</phase>
<configuration>
<skip>${web.e2e.disabled}</skip>
- <arguments>run test</arguments>
+ <target unless="skipTests">
+ <exec executable="./zeppelin-daemon.sh"
dir="${zeppelin.daemon.package.base}" spawn="false">
+ <arg value="stop" />
+ </exec>
+ </target>
</configuration>
+ <goals>
+ <goal>run</goal>
+ </goals>
</execution>
-
- <execution>
- <id>npm e2e</id>
- <goals>
- <goal>npm</goal>
- </goals>
- <phase>integration-test</phase>
- <configuration>
- <skip>${web.e2e.disabled}</skip>
- <arguments>run e2e</arguments>
- </configuration>
- </execution>
-
Review Comment:
Is there any particular reason you removed the `frontend-maven-plugin`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
