tbonelee commented on code in PR #5072:
URL: https://github.com/apache/zeppelin/pull/5072#discussion_r2355380075
##########
.github/workflows/frontend.yml:
##########
@@ -85,6 +85,71 @@ jobs:
${{ runner.os }}-zeppelin-
- name: Run headless test
run: xvfb-run --auto-servernum --server-args="-screen 0 1024x768x24"
./mvnw package -pl zeppelin-web-angular ${MAVEN_ARGS}
+
+ run-playwright-e2e-tests:
+ runs-on: ubuntu-24.04
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v4
+ - name: Tune Runner VM
+ uses: ./.github/actions/tune-runner-vm
+ - name: Set up JDK 11
+ uses: actions/setup-java@v4
+ with:
+ distribution: 'temurin'
+ java-version: 11
+ - name: Set up Node.js 16
+ uses: actions/setup-node@v4
+ with:
+ node-version: 16
+ cache: 'npm'
+ cache-dependency-path: zeppelin-web-angular/package-lock.json
+ - name: Cache local Maven repository
+ uses: actions/cache@v4
+ with:
+ path: |
+ ~/.m2/repository
+ !~/.m2/repository/org/apache/zeppelin/
+ ~/.spark-dist
+ ~/.cache
+ key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ ${{ runner.os }}-zeppelin-
+ - name: Install Zeppelin backend
+ run: ./mvnw clean install -DskipTests -am -pl
zeppelin-server,zeppelin-web,zeppelin-web-angular -Pweb-classic
-Pspark-scala-2.12 -Pspark-3.4 -Pweb-dist ${MAVEN_ARGS}
Review Comment:
Maybe we don't need to install `zeppelin-web`. Also, not right now, but
later when we add tests, we could include the necessary interpreter modules
here as `-pl` arguments (similar to the `install environment` step in the
`zeppelin-integration-test` job).
```suggestion
run: ./mvnw clean install -DskipTests -am -pl
zeppelin-server,zeppelin-web-angular ${MAVEN_ARGS}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
