dididy commented on code in PR #5075:
URL: https://github.com/apache/zeppelin/pull/5075#discussion_r2355267754
##########
zeppelin-web-angular/src/app/share/page-header/page-header.component.ts:
##########
@@ -21,7 +21,7 @@ import { InputBoolean } from 'ng-zorro-antd/core/util';
})
export class PageHeaderComponent implements OnInit {
@Input() title!: string;
- @Input() description!: string | TemplateRef<void>;
+ @Input() description!: TemplateRef<void>;
Review Comment:
https://github.com/apache/zeppelin/pull/5075/files#diff-97564afdcc91a75edcc8c7cc380cee9de3ef14dd50ddb4e874becccb7423a15cR19
Wouldn’t this part(description) in page-header.component.html need to ensure
that the value of the `ngTemplateOutlet` attribute (**extra**) converges to
null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
