tbonelee commented on code in PR #5075:
URL: https://github.com/apache/zeppelin/pull/5075#discussion_r2357395427
##########
zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/paragraph.component.html:
##########
@@ -40,26 +40,27 @@
[colWidthOption]="colWidthOption"
[pid]="paragraph.id"
[isEntireNoteRunning]="isEntireNoteRunning"
- [(enabled)]="paragraph.config.enabled"
- [(tableHide)]="paragraph.config.tableHide"
- [(colWidth)]="paragraph.config.colWidth"
- [(title)]="paragraph.config.title"
- [(fontSize)]="paragraph.config.fontSize"
- [(lineNumbers)]="paragraph.config.lineNumbers"
- [(editorHide)]="paragraph.config.editorHide"
- [(runOnSelectionChange)]="paragraph.config.runOnSelectionChange"
- (tableHideChange)="commitParagraph()"
+ [enabled]="paragraph.config.enabled"
+ [tableHide]="paragraph.config.tableHide"
+ [colWidth]="paragraph.config.colWidth"
+ [titleShow]="paragraph.config.title"
+ [fontSize]="paragraph.config.fontSize"
+ [showLineNumbers]="paragraph.config.lineNumbers"
+ [editorHide]="paragraph.config.editorHide"
+ [runOnSelectionChange]="paragraph.config.runOnSelectionChange"
Review Comment:
For the
`PublishsedParagraphComponent`(`published/paragraph/paragraph.html`), it makes
sense to render `zeppelin-notebook-paragraph-result` only when `paragraph` is
defined. I've updated it so that it's rendered conditionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
