tbonelee commented on code in PR #5088:
URL: https://github.com/apache/zeppelin/pull/5088#discussion_r2400907040


##########
zeppelin-web-angular/pom.xml:
##########
@@ -247,6 +247,25 @@
         <web.e2e.enabled>true</web.e2e.enabled>
       </properties>
     </profile>
+    
+    <profile>
+      <id>e2e-anonymous</id>
+      <properties>
+        <web.e2e.disabled>false</web.e2e.disabled>
+        <web.e2e.enabled>true</web.e2e.enabled>
+        <test.groups>anonymous</test.groups>
+      </properties>
+    </profile>
+    
+    <profile>
+      <id>e2e-auth</id>
+      <properties>
+        <web.e2e.disabled>false</web.e2e.disabled>
+        <web.e2e.enabled>true</web.e2e.enabled>
+        <zeppelin.shiro.config>conf/shiro.ini</zeppelin.shiro.config>
+        <test.groups>authentication</test.groups>
+      </properties>
+    </profile>

Review Comment:
   Those two profiles look the same now. Do you have plans to differentiate 
them by profile in the future? If not, how about merging them into a single 
`e2e` profile here, and also using just `-Pe2e` in frontend.yml?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to