tbonelee commented on code in PR #5088:
URL: https://github.com/apache/zeppelin/pull/5088#discussion_r2402221255
##########
zeppelin-web-angular/pom.xml:
##########
@@ -247,6 +247,25 @@
<web.e2e.enabled>true</web.e2e.enabled>
</properties>
</profile>
+
+ <profile>
+ <id>e2e-anonymous</id>
+ <properties>
+ <web.e2e.disabled>false</web.e2e.disabled>
+ <web.e2e.enabled>true</web.e2e.enabled>
+ <test.groups>anonymous</test.groups>
+ </properties>
+ </profile>
+
+ <profile>
+ <id>e2e-auth</id>
+ <properties>
+ <web.e2e.disabled>false</web.e2e.disabled>
+ <web.e2e.enabled>true</web.e2e.enabled>
+ <zeppelin.shiro.config>conf/shiro.ini</zeppelin.shiro.config>
+ <test.groups>authentication</test.groups>
+ </properties>
+ </profile>
Review Comment:
Sorry, but just one last request 🙏 — in the frontend.yml, for the step “Run
headless E2E test with Maven”, wouldn’t it be possible to merge them without an
if/else as well? (That’s the only additional change I was hoping for.)
If there was another intention behind keeping them separate, please let me
know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
