seung-00 commented on PR #5099: URL: https://github.com/apache/zeppelin/pull/5099#issuecomment-3394152171
@Reamer In this case I applied it to both, as you mentioned, to make it easier to remove unreferenced parts later on. But I don’t think we need to do that for every task. Covering both sides would be a bit tricky, since the front-end codebases are quite different. @tbonelee I fixed the issue you mentioned. If the CI failed due to the login modal, I think the CI job might need to be adjusted instead, because the wsMaxMessageSize API doesn’t require authentication. However, I found that wsMaxMessageSize was being called and cached initially (same as before), but it’s only needed in specific cases (e.g., exporting/importing note). So I modified it to be called only when required, now the CI error no longer occurs. BTW, if the user isn’t logged in initially, showing the login modal seems natural. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
