tbonelee commented on PR #5099: URL: https://github.com/apache/zeppelin/pull/5099#issuecomment-3384778554
@seung-00 (If we also apply this to `zeppelin-web`.) There is a failing test in `zeppelin-integration`. After a quick note: in `zeppelin-web`'s `NoteImportCtrl`, `wsMaxMessageSize` is called even when the user is not logged in. The server then returns a 302 redirect to `/api/login` (`shiro.loginUrl`). When the login API responds with 405, the HTTP interceptor emits `session_logout` (https://github.com/apache/zeppelin/blob/f1f671394dc742ec35ede32be039850cdf8a1145/zeppelin-web/src/app/app.js#L170). The login controller listens for `session_logout` and programmatically clicks the login button (`.nav-login-btn`). As a result, the login modal pops up immediately when the window opens, which is different from before, and the integration test fails. It looks like we should change this to issue the API request only when the user is authenticated, or defer it until the moment it is actually needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
