dididy commented on code in PR #5109: URL: https://github.com/apache/zeppelin/pull/5109#discussion_r2455646751
########## zeppelin-web-angular/src/assets/classic-visualization-templates/columnselector_settings.html: ########## @@ -12,21 +12,50 @@ limitations under the License. --> <div - style="border: 1px solid #ddd; border-radius: 4px; box-shadow: 0 1px 1px rgba(0,0,0,.05); margin-top: 10px; margin-bottom: 11px; background-color: #fff;" + style=" + border: 1px solid #ddd; + border-radius: 4px; + box-shadow: 0 1px 1px rgba(0, 0, 0, 0.05); + margin-top: 10px; + margin-bottom: 11px; + background-color: #fff; + " > <div - style="background-color: #f5f5f5; border-bottom: 1px solid #ddd; border-radius: 3px 3px 0 0; padding: 6px 12px 6px 12px; font-size: 13px;" + style=" + background-color: #f5f5f5; + border-bottom: 1px solid #ddd; + border-radius: 3px 3px 0 0; + padding: 6px 12px 6px 12px; + font-size: 13px; + " > - <span style="vertical-align: middle; display: inline-block; margin-top: 3px; color: #333;">Available Fields</span> - <div style="clear: both;"></div> + <span style="vertical-align: middle; display: inline-block; margin-top: 3px; color: #333">Available Fields</span> Review Comment: It would be nice to have a consistent rule for this as well, since in some cases the styles are aligned with line breaks and in others they are not. ########## zeppelin-web-angular/src/polyfills.ts: ########## @@ -84,8 +74,8 @@ /*************************************************************************************************** * Zone JS is required by default for Angular itself. */ -// tslint:disable -import 'zone.js/dist/zone'; // Included with Angular CLI. +/* eslint-disable */ Review Comment: Does this really need to be here? It seems like removing it wouldn’t cause any issues. ########## zeppelin-web-angular/src/app/app-runtime-compiler.providers.ts: ########## Review Comment: <img width="634" height="190" alt="Image" src="https://github.com/user-attachments/assets/e32c9f99-24b6-42b6-8c9e-c678647f195f"; /> How about replacing the JIT-based `RUNTIME_COMPILER_PROVIDERS` with an Ivy-compatible approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
