tbonelee commented on code in PR #5109: URL: https://github.com/apache/zeppelin/pull/5109#discussion_r2456325507
########## zeppelin-web-angular/src/app/app-runtime-compiler.providers.ts: ########## Review Comment: I think replacing this with reliable, public APIs won't be straightforward. The Angular team has opposed exposing a runtime API that compiles string templates for security and performance reasons. (https://github.com/angular/angular-cli/issues/9306#issuecomment-378081686) We've also had to implement workarounds for related runtime-compiler/AOT issue. (https://github.com/apache/zeppelin/pull/4809) Given that, we may consider alternative approaches to rendering dynamic templates with data binding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
