Cristian wrote:
Hi,
I see that the actual implementation of load_response.tcl produces a increasingly nested list when parsing multiple values for a given key. I've corrected this by changing it to use concat instead of list (diff attached to be run in rivet/rivet-tcl/). I also saw that no test files were present for this command, so I wrote them too (attached load_response.rvt and load_response.test to be copied in tests/).

the load_response problem was discussed last February.
IIRC David explained that changing this function in
that way would have some side effects in case
list valued parameters are passed to the server (see the
list archives).

Still I need something different and
I wrote a 'load_response' method in the root class
of my pages that overrides in the rivet standard proc. This
method is the library function modified in the very same
way you did.

For tcltest I can't help: my ignorance about this package is vast.

-- Massimo

When running the tests, it was quite annoying that the results from previous tests was shown when a regexp didn't match. So I included set match "" all over the place, so now it is more clear that the regexp didn't match. I attached the diff also ( tests.diff to be applied in tests/). When time allows, I will be checking the other commands and their tests. Till now all the I18n tests fail on my utf-8 encoding system.

Could someone check this and commit if it applies?

Thanks.

Cristian.



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to