I'm OK with the WeblogTemplate rename and I'd like to do more, but we
need to careful with renaming right now. I'm doing major surgery (i.e.
a giant number of changes) on Roller in the Roller 2.0 branch to
introduce group blogging and a many-to-many relationship between user
and website. Rename will make my merge much more difficult, so let's
not go to town right now.
And yes, the *Data and *Assoc patterns are used in the XDoclet stuff.
- Dave
On Jun 29, 2005, at 9:24 AM, Allen Gilliland wrote:
From what I can tell the only thing that the *Data convention really
helps is the xdoclet calls. I've actually tested the change from
PageData to WeblogTemplate and the only part that took a little
finessing was the xdoclet calls.
Personally, I prefer that we just choose the best possible names for
the classes rather than always try and follow the *Data convention.
-- Allen
On Wed, 2005-06-29 at 08:06, Anil Gangolli wrote:
Actually, we may be using *Data as a pattern for applying Xdoclet.
I'm not in a position to check the sources right now. But this
is something to check.
--a.
----- Original Message -----
From: "Anil Gangolli" <[EMAIL PROTECTED]>
To: <[email protected]>
Sent: Wednesday, June 29, 2005 8:04 AM
Subject: Re: rename PageData to WeblogTemplate?
I thought the "*Data" suffix pattern is currently used on all of the
pojos deriving from PersistentObject. Following this, you
would have WeblogTemplateData. Are we moving away from this? I'm
not sure if it adds value any longer, but I think we should
make it a conscious decision to move away from that pattern on the
whole (which would be ok with me).
--a.
----- Original Message -----
From: "Allen Gilliland" <[EMAIL PROTECTED]>
To: "roller-dev" <[email protected]>
Sent: Tuesday, June 28, 2005 4:19 PM
Subject: rename PageData to WeblogTemplate?
would anybody be upset if I renamed the PageData class to
WeblogTemplate? I figured that since I am already having to do
some
alterations to make way for theme templates that it would be nice
to be consistent.
Right now I have ...
Template (interface)
- ThemeTemplate (implements Template)
Then I would rename PageData to WeblogTemplate to follow the
pattern. WeblogTemplate seems pretty good since it is basically a
template that is attached to a specific weblog. This won't
actually change any functionality, just a naming thing really.
-- Allen
