Dave, were you able to gather any more info about when the blank screen problem was happening on your site? like what the url was, what the cache key was, what the response code was, etc? It sounds like this is something wrong with how the request stack is being processed.
If simply moving the RequestFilter back to its earlier position in the filter chain has solved the problem then that should help us identify where the problem lies, however I don't think that is the long term solution. The RollerRequest object does a lot of talking to the db, so we should really try and keep it where it is now, after the caching filters. I've just commited a couple small changes which may help a little. The most important one is a small modification to the RequestFilter so that if it catches an exception while constructing the RollerRequest it now sets the "DisplayException" request attribute so that the cache filters know not to cache the result. This wasn't happening before because the RequestFilter has traditionally been one of the first filters in the chain. I also still think we should not need the RequestFilter at all anymore. In Roller 2.0 the RequestFilter did 3 things ... 1. create a RollerRequest object (parse and validate request, fetch data from db) 2. rememberMe cookie logic 3. set updateTime request attribute if it wasn't set #2 is gone now because we have Acegi. and I moved #3 into the FlavorServlet because it only pertains to rss feeds anyways. This means that right now the only thing the RequestFilter does is create a RollerRequest object so it can be used later on, and I think we should be fine simply letting our servlets do this rather than doing it in a filter. -- Allen On Mon, 2005-12-05 at 05:43, Dave Johnson wrote: > I added the RequestFilter back into the chain saturday and the blank > screen problems have completely disappeared, but I did get a crash on > Sunday. The JVM again disappeared without leaving any log messages. > This is significant; I haven't see crashes like this before. > > - Dave > > > > On Dec 3, 2005, at 6:30 PM, Dave Johnson wrote: > > > Just a word of warning. Thursday, I deployed the latest code in the > > Roller trunk to my site and since then my site's main page has gone > > blank three times (I restored the page by clearing the site-wide page > > cache) and the site has crashed twice (the JVM crashes, leaving no > > stack trace). If you want to check out the new features you might want > > to do it on a test system only. I'm not sure what's going on yet. I'll > > be working on isolating the problem once I get back to work on Monday. > > > > - Dave > > >
