On Mon, 2005-12-05 at 09:51, Dave Johnson wrote:
> On Dec 5, 2005, at 12:38 PM, Allen Gilliland wrote:
> > were you able to gather any more info about when the blank screen
> > problem was happening on your site? like what the url was, what the
> > cache key was, what the response code was, etc? It sounds like this is
> > something wrong with how the request stack is being processed.
>
> No, I wasn't able to figure out which URL was causing the problem.
the problem was happening on the main page though, so /main.do right?
>
>
> > If simply moving the RequestFilter back to its earlier position in the
> > filter chain has solved the problem then that should help us identify
> > where the problem lies, however I don't think that is the long term
> > solution. The RollerRequest object does a lot of talking to the db, so
> > we should really try and keep it where it is now, after the caching
> > filters.
>
> Yes, I too would like to figure out how to get RequestFilter out of the
> picture.
>
> I suspect that the problem is that we now catch template not found
> problems in BasePageServlet, which is behind cache filter, rather
> than the RequestFilter which is in front of the cache filter.
gotcha.
>
>
> > I've just commited a couple small changes which may help a little. The
> > most important one is a small modification to the RequestFilter so that
> > if it catches an exception while constructing the RollerRequest it now
> > sets the "DisplayException" request attribute so that the cache filters
> > know not to cache the result. This wasn't happening before because the
> > RequestFilter has traditionally been one of the first filters in the
> > chain.
>
> That may solve the problem. But, I thought we wanted to remove
> the RequestFilter entirely?
yes, that is definitely the ultimate goal.
>
> Perhaps BasePageServlet should throw an exception and/or a
> 404 when an invalid page template is requested.
that sounds pretty reasonable. if we do a
request.setAttribute("DisplayException", exception); in the
BasePageServlet then that will be enough to allow the cache filters to
know they should disregard anything from the cached response content.
it would also make sense to send a 404 as well.
-- Allen
>
> - Dave
>
