This looks like a safe patch. I'll go ahead and commit.
-Elias
Stefan Eissing wrote:
> Ok, so this list strips attachments, fair enough:
> ===================================================================
> --- build.sh (revision 395559)
> +++ build.sh (working copy)
> @@ -1,17 +1,29 @@
> #!/bin/bash
> +
> +# OS specific support. $var _must_ be set to either true or false.
> +cygwin=false
> +os400=false
> +case "`uname`" in
> +CYGWIN*) cygwin=true;;
> +OS400*) os400=true;;
> +esac
> +
> +CPSEP=":"
> +if $cygwin; then CPSEP=";"; fi
> +
> if [ "$JAVA_HOME" = "" ] ; then
> echo You must set JAVA_HOME to point to your Java JDK install directory
> exit 1
> fi
> rocp=${JAVA_HOME}/lib/tools.jar
> -rocp=${rocp}:./tools/buildtime/ant-1.6.2/ant.jar
> -rocp=${rocp}:./tools/buildtime/ant-1.6.2/ant-launcher.jar
> -rocp=${rocp}:./tools/buildtime/ant-1.6.2/ant-junit.jar
> -rocp=${rocp}:./tools/buildtime/ant-1.6.2/ant-commons-net.jar
> -rocp=${rocp}:./tools/buildtime/ant-1.6.2/commons-net-1.2.2.jar
> -rocp=${rocp}:./tools/buildtime/ant-1.6.2/jakarta-oro-2.0.8.jar
> -rocp=${rocp}:./tools/buildtime/junit-3.8.1.jar
> +rocp=${rocp}${CPSEP}./tools/buildtime/ant-1.6.2/ant.jar
> +rocp=${rocp}${CPSEP}./tools/buildtime/ant-1.6.2/ant-launcher.jar
> +rocp=${rocp}${CPSEP}./tools/buildtime/ant-1.6.2/ant-junit.jar
> +rocp=${rocp}${CPSEP}./tools/buildtime/ant-1.6.2/ant-commons-net.jar
> +rocp=${rocp}${CPSEP}./tools/buildtime/ant-1.6.2/commons-net-1.2.2.jar
> +rocp=${rocp}${CPSEP}./tools/buildtime/ant-1.6.2/jakarta-oro-2.0.8.jar
> +rocp=${rocp}${CPSEP}./tools/buildtime/junit-3.8.1.jar
> ${JAVA_HOME}/bin/java -Xmx512m -Djava.home=${JAVA_HOME} -classpath
> ${rocp} org.apache.tools.ant.Main $1 $2 $3 $4 $5
>
>
> Am 20.04.2006 um 14:04 schrieb Stefan Eissing:
>
>> Hi,
>>
>> after having setup up roller successfully I wanted to dig into the
>> sources a bit and did the svn checkout. When I tried to run the
>> build.sh under Windows using cygwin, it failed since the classpath
>> uses the "wrong" separator.
>>
>> I made a workaround based on the catalina start up script and attach
>> the svn diff to this mail. I hope that this is the way one can
>> contribute patches, otherwise please let me know how to proceed.
>>
>> Best Regards, Stefan
>> ----------------------------------------------------
>
>