Hello Stefan. Could you please elaborate on how you mean you get the
test cases to run successfully? I have just now downloaded Roller 2.1.1
release. I ran build all and the build tests. First of all I had to
create the directory testdata, this is a bug in the current release, but
from how I have understood the situation it will be fixed in the next
release. Subsequently, after I created the testdata directory, I get
build successfull. But have you really looked at the output carefully?
When I check the ../build/reports/business/junit-noframes.html file to
check more closely which tests that have failed, I see a ton of errors.
Out of 55 tests, I get 46 errors and 7 failures.
I hope this is only me, and I have done something wrong. Could you
please check this?
Regards Shervin Asgari
Stefan Eissing wrote:
You maybe should take a release branch then. 2.1 compiles the test
cases.
//Stefan
Am 20.04.2006 um 14:47 schrieb Shervin Asgari:
Yeah...Too bad though. Because testing is quite important :)
We are making a multi domain support for roller, and we REALLY want
to make tests, but we need to make the existing tests work first,
and we get failures with the svn and the current release. :(
Shervin
Stefan Eissing wrote:
Shervin,
I have the same compile failure on the test code. Everything else
builds fine and the most common "all" build target does not build
the test code - that might explain why the error is still there.
Usually someone updates/fixes the main code and does not run the
tests which still call the "old" constructor.
best regards, Stefan
Am 20.04.2006 um 14:22 schrieb shervin:
Hi Stefan. I recently (today) downloaded the newest SVN trunk. I
also ran the build.sh but on Linux. When I tried to run build
tests I got compile error on WebsiteData class. I managed to fix
two errors, but still I get error when running the tests.
Do you also have the same problem?
It's strange that people upload classes which have compile error
on them. But I guess it is better to upload something
unfinished, rather than not?
PS: Here is a output of my error
[javac] Compiling 45 source files to /crypt/home/shervin/
workspace/rollerSVN/build/tests/WEB-INF/classes
[javac] /crypt/home/shervin/workspace/rollerSVN/tests/org/
roller/ RollerTestBase.java:164: cannot resolve symbol
[javac] symbol : constructor WebsiteData
(<nulltype>,java.lang.String,java.lang.String,java.lang.String,org.r
ol
ler.pojos.UserData,java.lang.String,java.lang.String,java.lang.Boole
an
,<nulltype>,<nulltype>,java.lang.String,java.lang.String,java.lan
g.Boo
lean,java.lang.Boolean,java.lang.String,java.lang.Boolean,java.lang.
St ring,java.util.Date,java.lang.Boolean,int,java.lang.Boolean)
[javac] location: class org.roller.pojos.WebsiteData
[javac] WebsiteData website = new WebsiteData(
[javac] ^
[javac] 1 error
BUILD FAILED
/crypt/home/shervin/workspace/rollerSVN/build.xml:737: Compile
failed; see the compiler error output for details.
Kind Regards Shervin Asgari
Stefan Eissing wrote:
Ok, so this list strips attachments, fair enough:
===================================================================
--- build.sh (revision 395559)
+++ build.sh (working copy)
@@ -1,17 +1,29 @@
#!/bin/bash
+
+# OS specific support. $var _must_ be set to either true or false.
+cygwin=false
+os400=false
+case "`uname`" in
+CYGWIN*) cygwin=true;;
+OS400*) os400=true;;
+esac
+
+CPSEP=":"
+if $cygwin; then CPSEP=";"; fi
+
if [ "$JAVA_HOME" = "" ] ; then
echo You must set JAVA_HOME to point to your Java JDK
install directory
exit 1
fi
rocp=${JAVA_HOME}/lib/tools.jar
-rocp=${rocp}:./tools/buildtime/ant-1.6.2/ant.jar
-rocp=${rocp}:./tools/buildtime/ant-1.6.2/ant-launcher.jar
-rocp=${rocp}:./tools/buildtime/ant-1.6.2/ant-junit.jar
-rocp=${rocp}:./tools/buildtime/ant-1.6.2/ant-commons-net.jar
-rocp=${rocp}:./tools/buildtime/ant-1.6.2/commons-net-1.2.2.jar
-rocp=${rocp}:./tools/buildtime/ant-1.6.2/jakarta-oro-2.0.8.jar
-rocp=${rocp}:./tools/buildtime/junit-3.8.1.jar
+rocp=${rocp}${CPSEP}./tools/buildtime/ant-1.6.2/ant.jar
+rocp=${rocp}${CPSEP}./tools/buildtime/ant-1.6.2/ant-launcher.jar
+rocp=${rocp}${CPSEP}./tools/buildtime/ant-1.6.2/ant-junit.jar
+rocp=${rocp}${CPSEP}./tools/buildtime/ant-1.6.2/ant-commons- net.jar
+rocp=${rocp}${CPSEP}./tools/buildtime/ant-1.6.2/commons-
net-1.2.2.jar
+rocp=${rocp}${CPSEP}./tools/buildtime/ant-1.6.2/jakarta-
oro-2.0.8.jar
+rocp=${rocp}${CPSEP}./tools/buildtime/junit-3.8.1.jar
${JAVA_HOME}/bin/java -Xmx512m -Djava.home=${JAVA_HOME} -
classpath $ {rocp} org.apache.tools.ant.Main $1 $2 $3 $4 $5
Am 20.04.2006 um 14:04 schrieb Stefan Eissing:
Hi,
after having setup up roller successfully I wanted to dig into
the sources a bit and did the svn checkout. When I tried to
run the build.sh under Windows using cygwin, it failed since
the classpath uses the "wrong" separator.
I made a workaround based on the catalina start up script and
attach the svn diff to this mail. I hope that this is the way
one can contribute patches, otherwise please let me know how
to proceed.
Best Regards, Stefan
----------------------------------------------------
