Not at all.
Originally I did what you did, but it's not enough - ./buildpackage debian src doesn't work and ./buildpackage src produces different paths to originally (because tar follows the symlink before tar-ing).
With just your patch, clean "/.buildpackage debain" were failing and symlinks-to-self of citadel was created in the citadel folder and of libcitadel in the libcitadel folder which made builds fail.
Sam
diff --git a/citadel/buildpackages b/citadel/buildpackages index 8b18185..e78cc71 100755 --- a/citadel/buildpackages +++ b/citadel/buildpackages @@ -29,7 +29,7 @@ else fi if test "$done" = "false"; then cd .. - ln -sf citadel "citadel-$CITADEL_VERSION" + #ln -sf citadel "citadel-$CITADEL_VERSION" cd "citadel-$CITADEL_VERSION" else cd "../citadel-$CITADEL_VERSION" @@ -47,18 +47,17 @@ case $1 in fi if test "$2" == "src"; then - cd .. - rm -rf tmp - mkdir tmp - cp -rL citadel-$CITADEL_VERSION tmp - cd tmp/citadel-$CITADEL_VERSION + rm -fr ../tmp/citadel-$CITADEL_VERSION + mkdir -p ../tmp/citadel-$CITADEL_VERSION + cp -rL . ../tmp/citadel-$CITADEL_VERSION + cd ../tmp/citadel-$CITADEL_VERSION rm -rf `find -name .svn ` svn*tmp config.log config.status find -type f -exec chmod a-x {} \; chmod a+x configure *.sh *.sh.in debian/rules debian/*inst* debian/rules mkinstalldirs cd .. tar -chzf citadel_${CITADEL_VERSION}.orig.tar.gz citadel-${CITADEL_VERSION}/ --exclude "debian/*" pwd - cd citadel-${CITADEL_VERSION}; debuild -S -sa -kw.goesg...@outgesourced.org + cd citadel-${CITADEL_VERSION} && debuild -S -sa -kw.goesg...@outgesourced.org else fakeroot dpkg-buildpackage fi @@ -100,8 +99,8 @@ email=cita...@outgesourced.org ;; sourcedist) - cd ..; tar --exclude .svn --exclude "debian/*" -chvzf citadel-$CITADEL_VERSION.tar.gz citadel-$CITADEL_VERSION/ - ;; + cd ..; tar --exclude .svn --exclude "debian/*" -chvzf citadel-$CITADEL_VERSION.tar.gz --transform "s/^citadel/citadel-${CITADEL_VERSION}/" citadel/ + ;; *) echo "Not yet implemented. we have: debian " ;;