On 13.11.2010 19:22, Colin Finck wrote:
Sven Barth <[email protected]> wrote:
Shouldn't it be "_RTL_DRIVE_LETTER_CURDIR" instead of
"RTL_DRIVE_LETTER_CURDIR"?

It doesn't matter if you just define a variable using this structure
like "RTL_DRIVE_LETTER_CURDIR MyVariable;".

It just matters if you somewhere declare it as "struct
RTL_DRIVE_LETTER_CURDIR MyVariable;".
If this isn't done anywhere, we could even create an anonymous structure
(Microsoft extension to the C language) by defining the structure as
"typedef struct {...} RTL_DRIVE_LETTER_CURDIR, *PRTL_DRIVE_LETTER_CURDIR;"

But as all headers out there seem to define it as "typedef struct
RTL_DRIVE_LETTER_CURDIR", we should do as well to ensure compatibility
with all applications using the structure :-)

It just caught my eye cause every other struct definition in the ReactOS headers (that I've seen so far) is named with a leading underscore...

But thank you for your explanation why this isn't a problem.

Regarding the anonymous structure: wouldn't this break compatibility with gcc? (I don't know what features gcc supports ^^)

Regards,
Sven

_______________________________________________
Ros-dev mailing list
[email protected]
http://www.reactos.org/mailman/listinfo/ros-dev

Reply via email to