I think the last thing to be moved into NtUser is scroll bar classes. On Wed, Feb 22, 2017 at 10:57 AM, Alexander Rechitskiy <art1st...@yandex.ru> wrote:
> Problem of mouse capture also could be found in this bug-report > > > 1. CORE-12192 <https://jira.reactos.org/browse/CORE-12192> ONLYOFFICE > on ReactOS > > > 22.02.2017, 16:36, "Hermès BÉLUSCA-MAÏTO" <hermes.belu...@sfr.fr>: > > Hi ! > > Thanks for the notification James. > > To answer Giannis’ question, I was asking the status because I did a ~= 2 > hour long testing in “real-life” conditions of Word yesterday to see how > many bugs (visual or not) were existing. I’ve mainly played with different > tools in the ribbon bar, modified display of the document, inserted a > screenshot taken with the word’s tool (which I was surprised to see that it > did work great) etc etc… , and **many** spammy win32k fixme / err / etc… > appeared, most of them that already appear with other software as well. I > give here few examples: > > > > - > (C:\Buildslave\Build_MSVC_x86\build\reactos\win32ss\user\ntuser\scrollbar.c:1216) > err: FIXME: EnableScrollBar wSBflags 1 wArrows 0 Chg 0 > > This fixme spams a lot when word starts. I’ve checked the corresponding > ntuser code, and the fixme seems to be there because the drawing code of > the scrollbars (in user32/win32k) was not completely moved into win32k > during the class rewrite. I’ve also noted code redundancies between the > scroll.c file in user32 and the file of same name in ntuser. So this is one > place where I can touch the code. > > > > - We also have many of these errors: > > (C:\Buildslave\Build_MSVC_x86\build\reactos\win32ss\user\ntuser\message.c:1258) > err: UserPostMessage: Invalid handle 0xBC65036C Msg 0x2a3! > > (C:\Buildslave\Build_MSVC_x86\build\reactos\win32ss\user\ntuser\winpos.c:3309) > err: NtUserSetWindowPos bad window handle! > > (C:\Buildslave\Build_MSVC_x86\build\reactos\win32ss\user\ntuser\cursoricon.c:815) > err: Trying to delete global cursor! > > That may indicate someone (word, or us, within win32k calls) giving > incorrect parameters to the functions (because e.g. some win32k object died > in the meantime, or I don’t know). With Word, the appearance of these > messages is accompanied by either slowdowns or the cursor that remain of > the same shape when hovering on regions of word app window where it should > change its shape, etc.. > > > > - And other errors that we are used to see in our debug logs… > > > > Plus there is the problem of mouse capture that appear when you try to > resize word (or any other office app) window. > > > > Therefore that’s why I was wondering in advance whether there were other > people touching these similar win32k areas, before I’m potentially doing > anything there. > > > > Best, > > Hermès > > > > *De :* Ros-dev [mailto:ros-dev-boun...@reactos.org] *De la part de* James > Tabor > *Envoyé :* mercredi 22 février 2017 03:42 > *À :* ReactOS Development List > *Objet :* Re: [ros-dev] Office (Excel, Word...) 2010 on ReactOS > > > > Class rewrite is now done! Giannis plugged in the remainder with > Versioning so it's done. > > I noticed this on the mail list, having email problem. > > James > > > > On Tue, Feb 21, 2017 at 8:22 PM, Javier Agustìn Fernàndez Arroyo < > elh...@gmail.com> wrote: > > that´s amazing! > > congratulations! it´s wonderful to read such big news! :) > > ReactOS (and you, devs, of course) is going to conquer desktop world! :) > > > > On Wed, Feb 22, 2017 at 12:46 AM, Giannis Adamopoulos < > giannis.adamopou...@reactos.org> wrote: > > Jim completed the class rewrite years ago (with a great success) and afaik > there is no other major rewrite/undertaking right now in win32k. Why do I > have a feeling you plan some major undertaking? > > ReactOS Development List <ros-dev@reactos.org> wrote on Wed, February > 22nd, 2017, 12:01 AM: > > Hi all, > > > > > > > > Before touching parts of win32ss (user32/gdi32/win32k) I would like to > know > > what the status of different components are: > > > > - James, have you finished with your win32 class rewrite? What’s > > the status of it? Is there a bug report concerning this rewrite? > > > > - Does anybody else currently work on cursors / GDI bitmap > matters? > > > > > > > > Best, > > > > Hermès > > > > > > > > > > > > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de victor > > martinez > > Envoyé : mardi 21 février 2017 23:35 > > À : ReactOS Development List > > Objet : Re: [ros-dev] Office (Excel, Word...) 2010 on ReactOS > > > > > > > > Somehow it reminds me to the release/capture issues GIMP is showing with > the > > mouse: > > <https://jira.reactos.org/browse/CORE-11775> > > https://jira.reactos.org/browse/CORE-11775 > > > > _____ > > > > De: Ros-dev <ros-dev-boun...@reactos.org> en nombre de Giannis > Adamopoulos > > <giannis.adamopou...@reactos.org> > > Enviado: martes, 21 de febrero de 2017 11:50:04 > > Para: ReactOS Development List > > Asunto: Re: [ros-dev] Office (Excel, Word...) 2010 on ReactOS > > > > > > > > Hi! This is excellent news! It's good to know that Samuel started working > > again on ntlm. I guess the most productive way to help him complete it > would > > be to write several tests for it (and also convert Samuel's test to > formal > > tests). Not only will it help Samuel but will help you understand ntlm > > yourself and then help Samuel. (It is not like I knew anything about > > activation contexts before. It was the tests I wrote that helped me come > up > > with clever way to let our comctl32 really do what both versions of > > comctl32). > > > > Keep up the good work! > > > > PS: regarding the capture problems I would suggest writing more tests! > > (Win32k is so hard to come right that you are searching in the dark > unless > > you test it thoroughly). My instinct says that this is the same bug with > the > > spider solitaire where the last card isn't released when you win a game. > > There is a bug report for that but I don't remember the number. I think > that > > if the mouse button is released we should also release capture (and this > > needs testing, perhaps even interactive testing). > > > > Giannis > > > > ReactOS Development List < <mailto:ros-dev@reactos.org> > ros-dev@reactos.org> > > > wrote on Tue, February 21st, 2017, 2:59 AM: > > > Hello everyone, > > > > > > Today I was finally able to finish the installation of Office 2010 in > > > ReactOS, using as a temporary measure the Wine’s NTLM layer that calls > > into > > > the ntlm_auth utility of Samba. This was done while Samuel is > completing > > his > > > NTLM implementation. > > > As this wine layer is here running on ReactOS, few modifications were > > > needed, and I also needed to find a Windows build of Samba. I’ve found > > one, > > > by chance, at http://smithii.com/samba . Then, using ReactOS revision > > 73868 > > > (or later), and using this version of Samba, the Office installation > > > finishes (reminder: the problem was due to the fact the installer > needed > > > NTLM to communicate with the “Office Software Platform Service”, > > > OSPPSVC.EXE). We are now able to use Excel, Word, … on ReactOS, as > shown > > in > > > this picture: > > > http://i.imgur.com/fLEwoVI.png > > > > > > There are now 2 main problems: > > > - NTLM should be correctly implemented; > > > - There are an awful lot of drawing problems with Office 2010 > applications > > > (similar to those of Office 2007 apps): for example, dragging the graph > > > downwards shows his frame going upwards; there are many black regions > that > > > show up, etc...: It seems we have problems in coordinate frames. And > other > > > problems too. Also, we have some mouse capture problems: if you try to > > > redimension the windows the normal way (bring mouse cursor on top of > the > > > border, left-click-maintained, move mouse, release left button), and > then > > > move the mouse inside the window, it continues to be redimensioned... > > > As a result, I took ~=15 minutes to make this simple trivial picture > > above, > > > almost all the time taken to fight against window dimensioning & the > > drawing > > > problems. > > > > > > But anyways, enjoy ! > > > > > > This will be part of my next blog report. > > > > > > Cheers, > > > Hermès > > > > > > > > > _______________________________________________ > > > Ros-dev mailing list > > > > <mailto:Ros-dev@reactos.org> Ros-dev@reactos.org > > > <http://www.reactos.org/mailman/listinfo/ros-dev> > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > _______________________________________________ > > Ros-dev mailing list > > <mailto:Ros-dev@reactos.org> Ros-dev@reactos.org > > <http://www.reactos.org/mailman/listinfo/ros-dev> > > > http://www.reactos.org/mailman/listinfo/ros-dev > > _______________________________________________ > > Ros-dev mailing list > > Ros-dev@reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > _______________________________________________ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > _______________________________________________ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > > , > > _______________________________________________ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > > > -- > Best regards, > > > _______________________________________________ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >
_______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev