From: Silvan <[EMAIL PROTECTED]>
On Tuesday 14 September 2004 11:05 pm, Matthias Neeracher wrote:- My patch replaces references to Qt::whatever with the hardcoded color
values. This is not all that pretty, but the probability of Qt::red
being changed to a different RGB value are pretty low :-)
Interesting. Surely that isn't really the correct way to fix this, but I
guess sometimes there's ideologically correct, and then there's getting it
done today.
So what does that get you on OS-X now?
It seems that Rosegarden is now basically functional, minus the actual Audio I/O, which is going to take a few weeks. I am an experienced CoreAudio programmer, but not yet CoreMidi. Furthermore, it seems that there is no formal documentation for the SoundDriver interface (or is there? I'd appreciate any pointers).
From: Guillaume Laurent <[EMAIL PROTECTED]>
On Wednesday 15 September 2004 05:05, Matthias Neeracher wrote:
- My patch replaces references to Qt::whatever with the hardcoded color
values. This is not all that pretty, but the probability of Qt::red
being changed to a different RGB value are pretty low :-)
Silvan, I see you applied this patch : please revert it. There's a better way
to fix this without resorting to ugly magic numbers (no matter how unlikely
they are to change).
This is, of course, your call to make. I experimented with one design which preserved the symbolic
Qt constants (by writing a lazy wrapper for QColor and an explicit initialization function to be called from main),
but that required small changes in lots of files and colours.cpp itself was much uglier.
If I had written the code in question from scratch, my instinct would have been to bundle all the colors in a
singleton struct, but I suppose this design would not fit in at all with the current Rosegarden style, from what I can see.
I should also point out that the file was already full of ugly magic numbers BEFORE I touched it :-)
In fact, the constants I substituted happen to be precisely the RGB values that are trivial to figure out in one's head, because they only involve 0, 127, and 255. All the nontrivial colors were already hardcoded.
Matthias
------------------------------------------------------- This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE for your judgement on who ports your project to Linux PPC the best. Sponsored by IBM. Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php _______________________________________________ Rosegarden-devel mailing list [EMAIL PROTECTED] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
