On Wednesday 14 December 2005 23:43, Chris Cannam wrote:
>
> The reason for this is actually pretty simple. [...]

> The area covered by the Qt paint event is the latter; when repainting
> into the buffer, it isn't safe to assume that this is the full extent
> of the area that's actually changed.

Yes, that's more or less what I was trying to explain. The update requests 
being processed asynchronously and cumulated (and not necessarily coming from 
us only, to boot), we don't know that what we're going to repaint is really 
what we requested to update. We just know that it includes it.

> We'd need to record that 
> separately, for example by replacing m_segmentsDrawBufferNeedsRefresh
> with a QRect describing which area of the buffer needs to be refreshed.

I've come to the same conclusion.

> I do rather fear that, though.  It's a very simple change, but one that
> could make a lot of detail work.  I'd like to think it over a bit
> before I'm sure I'd want to recommend it, as I may have made a mistake
> somewhere.

Well, theoretically the only places where we'd need to maintain this "draw 
buffer update rect" is in the implementation of the SegmentObserver 
interface. However, I agree that it will probably get more complicated than 
that.

Another question : is it worth doing this for the beta ?

-- 
Guillaume.
http://www.telegraph-road.org


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to