clang detects this:
src/sound/MidiEvent.cpp:179:39: warning: adding 'int' to a string does not
append to the string [-Wstring-plus-int]
The code is
case MIDI_KEY_SIGNATURE:
tonality = (int)midiEvent.m_metaMessage[0];
if (tonality < 0) {
sharpflat = -tonality + " flat"; // HERE
} else {
sharpflat = tonality; // AND HERE
sharpflat += " sharp";
}
where sharpflat is a std::string, and tonality is an int.
This code looks very suspicious indeed. Was it means to convert the int to a
std::string?
(in C++11 this can be done with std::to_string(tonality)).
Asking for feedback because I don't use MidiEvent at all.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
