On Mon, 3 Dec 2018, at 11:43, Chris Cannam wrote:
> While I'm here I'll see about fixing a few of these.

I've checked and fixed (or in one case just left an explanatory comment about) 
the ones listed at the bottom of this email.

I haven't fixed any of the large number of inconsistent nullptr checks, or the 
exception stuff (catching by value). I think the least intrusive way to fix the 
former is probably also rather labour-intensive, sadly. The latter ought to be 
amenable to automation I guess, but I don't have more time to look at that.


Chris

[E] V560 A part of conditional expression is always false: singleStaff. 
NotationScene.cpp 1707
[R] V547 Expression 'i > 5' is always false. SegmentParameterBox.cpp 323
[E] V547 Expression '""' is always true. LilyPondOptionsDialog.cpp 64
[E] V773 The function was exited without releasing the 'testFile' 
pointer. A memory leak is possible. RIFFAudioFile.cpp 561 (and the 
following two)
[E] V601 The integer type is implicitly cast to the char type. 
MidiEvent.cpp 181
[R] V674 The '0.1' literal of the 'double' type is compared to a value 
of the 'int' type. Consider inspecting the 'm_connectingLineLength > 
0.1' expression. StaffLayout.cpp 1028
[S] V601 The string literal is implicitly cast to the bool type. 
FileSource.cpp 902
[S] V783 Dereferencing of the invalid iterator 'i' might take place. 
IconStackedWidget.cpp 126
[S] V783 Dereferencing of the invalid iterator 'beatTimeTs.end()' might 
take place. CreateTempoMapFromSegmentCommand.cpp 119
[S] V783 Dereferencing of the invalid iterator 'm_segments.end()' might 
take place. StaffHeader.cpp 250
[S] V670 The uninitialized class member 'm_intervals' is used to 
initialize the 'm_size' member. Remember that members are initialized in 
the order of their declarations inside a class. Tuning.cpp 394
[E] V557 Array overrun is possible. The value of 'submaster' index could 
reach 64. SequencerDataBlock.cpp 325



_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to