2011/1/27 Jeff Johnson <n3...@mac.com>: > > On Jan 27, 2011, at 3:12 PM, Per Øyvind Karlsen wrote: > >>> >>> Yes its all very silly and stoopid. But I'll rot in hell before I get >>> blamed for >>> You broke yum by changing rpm-python @rpm5.org! >>> Which was the suggestion that Per Oyvind coordinate a tricky change first. >> Don't worry on labelCompare(), I find it rather inpractical and >> tedious to use compared >> to just passing EVR strings to evrCompare() for rpmEVRparse to take care of >> parsing it, rather than parsing it myself with ie. regexp and passing >> the parts of >> it as a tuple.. > > Well I delivered essentially that same statement to ssopw...@redhat.com > within 24 hours when he crufted up labelCompare() way back when. > > Life's too short to argue about whether 0 or NULL or "" or whatever is > The One Truly Pythonic Way to write code. > >> >> I'm afraid of touch existing functionality in the python bindings >> myself already anyways >> due to concern about legacy compatibility, by adding new functions I >> at least won't >> break anything existing, causing troubles for others.. ;) >> > > Hint: test cases. How convenient, I now can just convert the existing test case with labelCompare() in python/test/test_rpm.py to use evrCompare()! ;)
-- Regards, Per Øyvind ______________________________________________________________________ RPM Package Manager http://rpm5.org Developer Communication List rpm-devel@rpm5.org
