On 21 October 2016 at 08:51, Panu Matilainen <[email protected]> wrote:
>>> Please test and report any anomalies. From rc2 to final only regression >>> fixes will be allowed. Unless of course something really strange comes up, >>> you never know. Or I forgot something absolutely vital. THAT would not >>> count as a strange incident though. >> >> >> Humm.... Testsuite won't pass.... >> 2 tests are failing because of missing files... >> Please apply the attached patch >> It fixes: >> 84: rpmbuild debuginfo dwz FAILED (rpmbuild.at:396) >> 86: rpmbuild implicit suid binary FAILED (rpmbuild.at:509) > > > Ah, I did run the test-suite but not from the created tarball. One more thing > to remember when cutting releases. Or rather *cough* to document *cough*. > > Applied (with a slightly expanded comments). If you could cherry-pick in rpm-4.13.x branch too, that would be nice :-) >> After that, 2 unexpected failures remain: >> >> 85: rpmbuild debuginfo dwz gnu_debuglink crc FAILED (rpmbuild.at:468) > > > ...but this I had just missed. It appears to be cured by commit > cherry-picking commit 3929ce4d58ab18c810b9a776f5c49d56cb436026. This commit doen't exist in git The attached patch fixes it anyway >> 277: spec parse FAILED (rpmpython.at:70) > > > ...and this I'm not seeing at all. Please post > tests/rpmtests.dir/277/rpmtests.log ... or does it happen to go away if you > cherry-pick commit 3c74e34e8d8c5b3db024dbe04a352e807ed2b627 ? That doesn't help. I've attached the relevant logs plus a fix.
## ---------------------- ##
## Detailed failed tests. ##
## ---------------------- ##
# -*- compilation -*-
277. rpmpython.at:70: testing spec parse ...
./rpmpython.at:70:
cat << EOF > test.py
import rpm, sys
dbpath=rpm.expandMacro('%_dbpath')
rpm.addMacro('_dbpath', '${abs_builddir}/testing%s' % dbpath)
def myprint(msg = ''):
sys.stdout.write('%s\n' % msg)
# TODO: add a better test spec with sub-packages etc
spec = rpm.spec('${RPMDATA}/SPECS/hello.spec')
for (name, num, flags) in spec.sources:
myprint('src %s %d %d' % (name, num, flags))
for pkg in spec.packages:
myprint(pkg.header.format('%{nvr}'))
myprint(spec.sourceHeader.format('%{nvr}'))
EOF
python test.py
--- - 2016-10-21 10:36:41.596671971 +0200
+++
/home/tv/mga/pkgs/rpm/BUILD/rpm-4.13.0-rc2/tests/rpmtests.dir/at-groups/277/stdout
2016-10-21 10:36:41.593694885 +0200
@@ -1,5 +1,6 @@
src hello-1.0-modernize.patch 0 2
src hello-1.0.tar.gz 0 1
hello-1.0-1
+hello-debuginfo-1.0-1
hello-1.0-1
277. rpmpython.at:70: 277. spec parse (rpmpython.at:70): FAILED
(rpmpython.at:70)
0001-fix-calling-sepdebugcrcfix.patch
Description: application/binary
0001-fix-testsuite-adjust-pkg-list.patch
Description: application/binary
_______________________________________________ Rpm-maint mailing list [email protected] http://lists.rpm.org/mailman/listinfo/rpm-maint
