pmatilai commented on this pull request.
> + freeStringBuf(sb_stdout);
+ free(output);
+ return rc;
+}
+
+static rpmRC doCheckBuildRequires(rpmts ts, rpmSpec spec, int test)
+{
+ rpmRC rc = RPMRC_OK;
+ rpmps ps = rpmSpecCheckDeps(ts, spec);
+
+ if (ps) {
+ rpmlog(RPMLOG_ERR, _("Failed build dependencies:\n"));
+ rpmpsPrint(NULL, ps);
+ }
+ if (ps != NULL)
+ rc = RPMRC_MISSINGBUILDREQUIRES;
This latter (ps != NULL) is redundant, just move the rc setting to the if (ps)
case above. Sorry for missing on the previous rounds.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-238224478_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
