As the GH interface doesn't allow commenting on individual commits, I'll just
make a general comment... In the "Pass rpmts object to rpmSpecBuild()" commit,
there are two minor issues:
- a stray empty line added before buildSpec()
- a change to rpmbuild.c that belongs to the next commit (move to library,
return 11 on missing buildrequires)
Other than that, and the missing tests, it's looking quite okay now.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#issuecomment-492961283
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
