pmatilai commented on this pull request.
> + SKIPBLANK(parts->g,c);
+ parts->ge = parts->g;
+ while ((parts->ge[0] != 0) && (parts->ge[0] != ':')) {
+ parts->ge++;
+ if (parts->ge[0] == '{') {
+ if ((parts->ge = matchchar(parts->ge++, '{', '}')) == NULL)
+ return NULL;
+ }
+ }
+ } else {
+ return NULL;
+ }
+
+ /* be the trhird part starting by ':' is optional */
+ parts->h = parts->ge;
+ parts->ge = findParameterEnd(parts->h[0] == ':' ? parts->ge : --parts->ge);
Never use --/++ side-effects like that. You're even assigning to the same
variable so it should be just
```? parts->ge : parts->ge -1```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/746#pullrequestreview-252199254_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
