pmatilai commented on this pull request.
> str++;
}
return str;
}
+static void partsInit(macroPartition *parts)
+{
+ parts->f = parts->fe = NULL;
+ parts->g = parts->ge = NULL;
+ parts->h = parts->he = NULL;
+ parts->fn = parts->gn = parts->hn = 0;
+ return;
In general, never initialize more than one variable on a line, it only makes it
harder to read. In a case like this, just memset() to zero.
The return at end of void function is redundant.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/746#pullrequestreview-252203689_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
